Addon-viewport: Fix Galaxy S9's viewport size #9797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galaxy S9's viewport size is 740x360. See https://yesviz.com/devices/s9/.
|
I think Pixel and Pixel XL sizes are also incorrect. See https://material.io/resources/devices/. We should also add Galaxy Note 9 or 10 to the list too. |
ndelangen
approved these changes
Feb 14, 2020
|
Is it useful to have so many devices in the default list? |
shilman
changed the title
shilman
changed the title
|
Not if it remains flat. If we group by manufacturer, then we can expand the defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Galaxy S9's viewport size is 740x360. See https://yesviz.com/devices/s9/.
Issue:
What I did
Fixed Galaxy S9 viewport size in the viewport addon's defaults.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.